[Mooncake] Skip KV lookup for non-reachable SWA blocks#45444
Merged
Conversation
wzhao18
force-pushed
the
wzhao/cache-block-mask
branch
3 times, most recently
from
cd8b96e to
dfa9e74
Compare
wzhao18
changed the title
wzhao18
requested review from
ApostaC,
NickLucche,
orozery and
xuechendi
as code owners
Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
wzhao18
force-pushed
the
wzhao/cache-block-mask
branch
from
dfa9e74 to
0581dbb
Compare
ivanium
approved these changes
Jun 17, 2026
ivanium
left a comment
ivanium
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for looking into the issue and the fix!
njhill
approved these changes
Jun 18, 2026
Dao007forever
approved these changes
Jun 18, 2026
djramic
pushed a commit
to djramic/vllm
that referenced
this pull request
Jun 18, 2026
…45444) Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
…45444) Signed-off-by: wzhao18 <wzhao18.sz@gmail.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Jun 21, 2026
…45444) Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
…45444) Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
…45444) Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds some optimizations for reducing overhead in Mooncake KV offloading.
lookup, skip SWA blocks that are not eligible to be considered cache hit, using kv cache group'sreachable_block_mask.Noneas all-True mask forstore_mask, saving list construction overhead for full cache:masks.append([True] * num_chunks if mask is None else mask).Performance benchmark:
DeepSeek v4 TP4 on 4 x GB300:
Test Plan
Mooncake store unit tests:
tests/v1/kv_connector/unit/test_mooncake_store_coordinator.pytests/v1/kv_connector/unit/test_mooncake_store_worker.pyChecked output of dsv4 using KV offloading looks correct.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.