[Bugfix] Restore is_sym guard for zp in GPTQ/CT MoE to fix symmetric quant regression#45656
Merged
Conversation
Signed-off-by: yuwenzho <yuwen.zhou@intel.com>
4 tasks
bigPYJ1151
approved these changes
Jun 18, 2026
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
…quant regression (vllm-project#45656) Signed-off-by: yuwenzho <yuwen.zhou@intel.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Jun 21, 2026
…quant regression (vllm-project#45656) Signed-off-by: yuwenzho <yuwen.zhou@intel.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
…quant regression (vllm-project#45656) Signed-off-by: yuwenzho <yuwen.zhou@intel.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
…quant regression (vllm-project#45656) Signed-off-by: yuwenzho <yuwen.zhou@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix a regression introduced by #43409 (comment) that broke symmetric GPTQ MoE quants (e.g. Autoround) on NVIDIA GPUs.
#43409 removed the
if not self.quant_config.is_sym else Noneguard inAutoGPTQMoEMethod.get_fused_moe_quant_configso that CPU could pass synthesized zero points for symmetric models. However, this caused symmetric GPU quants (Autoround and standard GPTQ withis_sym=True) to pass meaninglessqzerostensors to the Marlin kernel, producing incorrect results.The same pattern existed in
CompressedTensorsWNA16MarlinMoEMethod.process_weights_after_loading, where theif not self.symmetric:guard was absent, risking incorrect zp registration for non-CPU symmetric backends.Fix
auto_gptq.pyandcompressed_tensors_moe_wna16_marlin.py: Restore theis_symguard with an explicit CPU exceptionTest Plan
CPU tests:
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.