[Rust Frontend] Return model metadata fields in /v1/models#45950
Merged
BugenZhao merged 3 commits intoJun 18, 2026
Conversation
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Member
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
djramic
pushed a commit
to djramic/vllm
that referenced
this pull request
Jun 18, 2026
…ect#45950) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
…ect#45950) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Jun 21, 2026
…ect#45950) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
…ect#45950) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
…ect#45950) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The Rust frontend's
GET /v1/modelsreturned onlyid,object,created, andowned_by, dropping the vLLM extension fields the Python frontend includes on each model card. Most visibly, it omittedmax_model_len. This brings the Rust/v1/modelsresponse into parity with the Python frontend so it stays a drop-in replacement.This was an unlisted gap (not on the #44280 roadmap);
/v1/modelsitself was already implemented, and the data was already available to the route.Changes
root,parent, andmax_model_lento the/v1/modelsmodel card, plus a real request-timecreated(it was hardcoded to0).max_model_lenandroot= model path. LoRA cards carryroot= adapter path,parent= base model, andmax_model_len=null.Notes
permissionis intentionally omitted. Python emits apermission: [ModelPermission()]array, but modern OpenAI removedpermissionfrom its/v1/modelsschema (the official SDKModeltype has no such field). Omitting it keeps the response aligned with the current OpenAI spec.