[Bugfix] [Parser] Fix Qwen3 latent bug in partial params dropping values containing <#46047
Merged
Merged
Conversation
…ining < _PARTIAL_PARAM_RE used [^<]*$ to capture in-progress parameter content. When a value contained a literal < (HTML, code, math like x<5), the regex failed to match entirely, silently dropping the parameter during streaming. Fix by changing [^<]*$ to (.*)$ so the capture group accepts any character including <. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Ben Browning <bbrownin@redhat.com>
sfeng33
approved these changes
Jun 18, 2026
divineearthly
pushed a commit
to divineearthly/vllm
that referenced
this pull request
Jun 19, 2026
…ues containing `<` (vllm-project#46047) Signed-off-by: Ben Browning <bbrownin@redhat.com> Signed-off-by: divineearthly <divineearthly@gmail.com>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Jun 21, 2026
…ues containing `<` (vllm-project#46047) Signed-off-by: Ben Browning <bbrownin@redhat.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
…ues containing `<` (vllm-project#46047) Signed-off-by: Ben Browning <bbrownin@redhat.com>
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
…ues containing `<` (vllm-project#46047) Signed-off-by: Ben Browning <bbrownin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In the new Qwen3 parser,
_PARTIAL_PARAM_REused[^<]*$to capture in-progress parameter content. When a value contained a literal<(HTML, code, math like x<5), the regex failed to match entirely. In practice this appears to be handled gracefully by the holdback mechanism. But, it is a latent bug even though I have not been able to trigger that in the real world so far outside of the unit tests here. There could be some specific scenario of generated arguments that triggers this in a live server, so better to clean this up before users hit it.Fix by changing
[^<]*$to(.*)$so the capture group accepts any character including <.Test Plan
Unit Tests
I added a couple unit tests specifically to reproduce. The test plan below runs those as well as all other parser engine, qwen3 and nemotron_v3 reasoning tests (because the nemotron parser inherits from the qwen one).
Test Result
Unit Tests