[Rust Frontend] Support thinking_token_budget for chat and completions#46137
Merged
BugenZhao merged 3 commits intoJun 22, 2026
Merged
Conversation
Signed-off-by: RickyChen / 陳昭儒 <ricky.chen@infinirc.com>
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dac87f740d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
BugenZhao
approved these changes
Jun 22, 2026
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Jun 22, 2026
vllm-project#46137) Co-authored-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Signed-off-by: RickyChen / 陳昭儒 <ricky.chen@infinirc.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com>
4 tasks
nkzhenhua
pushed a commit
to nkzhenhua/vllm
that referenced
this pull request
Jun 24, 2026
vllm-project#46137) Co-authored-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Signed-off-by: RickyChen / 陳昭儒 <ricky.chen@infinirc.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com>
qli88
pushed a commit
to qli88/vllm
that referenced
this pull request
Jun 26, 2026
vllm-project#46137) Co-authored-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Signed-off-by: RickyChen / 陳昭儒 <ricky.chen@infinirc.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com> Signed-off-by: Qiang Li <qiang.li2@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the
thinking_token_budgetrequest parameter in the Rust frontend, for both/v1/chat/completionsand/v1/completions, reaching parity with the Python frontend (tracked in #44280, "Request compatibility and validation"). Previously the Rust frontend parsedthinking_token_budgeton the chat endpoint but explicitly rejected it ("thinking_token_budget is not supported."), and the completions endpoint did not expose it at all. The V1 engine has supported the parameter since #20859 and the Python frontend exposes it on both endpoints, so this was a pure frontend gap. Normalization mirrors Python'svalidate_thinking_token_budget(None/-1→ unlimited; other negatives rejected; no upper bound) and happens once during lowering, so chat, completions, and/inference/v1/generatebehave consistently.