Skip to content

[ROCm] Begin Deprecation Window for CUDA_VISIBLE_DEVICES on ROCm#46636

Merged
tjtanaa merged 1 commit into
vllm-project:mainfrom
ROCm:micah/deprecate-cuda-vis-devices
Jun 24, 2026
Merged

[ROCm] Begin Deprecation Window for CUDA_VISIBLE_DEVICES on ROCm#46636
tjtanaa merged 1 commit into
vllm-project:mainfrom
ROCm:micah/deprecate-cuda-vis-devices

Conversation

@micah-wil

@micah-wil micah-wil commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

ROCm currently respects CUDA_VISIBLE_DEVICES in vLLM. This has been a recurring source of bugs, especially in distributed environments, e.g. when using Ray. Examples: #45998, #35069, #33305, #33308

Follow up: #39448

Signed-off-by: Micah Williamson <micah.williamson@amd.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added nvidia rocm Related to AMD ROCm labels Jun 24, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Jun 24, 2026

@tjtanaa tjtanaa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Jun 24, 2026
@tjtanaa tjtanaa added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 24, 2026
@tjtanaa tjtanaa enabled auto-merge (squash) June 24, 2026 16:00
@tjtanaa tjtanaa added this to the v0.24.0 cherrypick milestone Jun 24, 2026
@tjtanaa tjtanaa merged commit d6696e2 into vllm-project:main Jun 24, 2026
112 of 114 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Jun 24, 2026
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Jun 24, 2026
khluu pushed a commit that referenced this pull request Jun 25, 2026
)

Signed-off-by: Micah Williamson <micah.williamson@amd.com>
(cherry picked from commit d6696e2)
qli88 pushed a commit to qli88/vllm that referenced this pull request Jun 26, 2026
…m-project#46636)

Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Signed-off-by: Qiang Li <qiang.li2@amd.com>
wincent8 pushed a commit to wincent8/vllm that referenced this pull request Jun 29, 2026
…m-project#46636)

Signed-off-by: Micah Williamson <micah.williamson@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nvidia ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

2 participants