Skip to content

[Bugfix][Core] Avoid unused new_block_ids tracking without KV zeroing - #47723

Closed
chaunceyjiang wants to merge 1 commit into
vllm-project:mainfrom
chaunceyjiang:needs_kv_cache_zeroing
Closed

[Bugfix][Core] Avoid unused new_block_ids tracking without KV zeroing#47723
chaunceyjiang wants to merge 1 commit into
vllm-project:mainfrom
chaunceyjiang:needs_kv_cache_zeroing

Conversation

@chaunceyjiang

@chaunceyjiang chaunceyjiang commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Purpose

This weekend, we found that vLLM has a memory leak.
image

Our initial investigation suggests that it was introduced by #35219, where self.new_block_ids is not being cleared. this pr is a locally fixed version from our side.

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
@chaunceyjiang
[Bugfix][Core] Avoid unused new_block_ids tracking without KV zeroing
1ed5828 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@mergify mergify Bot added v1 bug Something isn't working labels Jul 6, 2026
@chaunceyjiang chaunceyjiang mentioned this pull request Jul 6, 2026
Merged
@njhill

njhill commented Jul 6, 2026

Copy link
Copy Markdown
Member

Thanks @chaunceyjiang, I incorporated a version of this into #44490 with you as co-author.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working v1

2 participants

@chaunceyjiang @njhill