Skip to content

PR #681 closed without review — clarification needed #690

Description

@Strongf-bob

Hi maintainers,

PR #681 (fix: add missing publishAt column to SkillPackage entity and contract) was closed earlier today without any review or comment.

This PR fixes a production issue: the publishAt field is written by publishSharedSkillPackage and filtered by the workspace-public provider (publishAt IS NOT NULL), but it was never declared as a column on the SkillPackage entity or the ISkillPackage contract. TypeORM silently drops the write, so the org market listing is always empty.

Changes:

  • packages/contracts/src/ai/skill.model.ts — add publishAt?: Date to ISkillPackage
  • packages/server-ai/src/skill-package/skill-package.entity.ts — add @Column({ type: 'timestamptz', nullable: true }) publishAt
  • .changeset/fix-publishAt-column.md — patch changeset

Could you let me know why it was closed? Happy to address any feedback or adjust the PR (e.g., target a different base branch).

Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions