Skip to content

feat: surface ReservationPath and Reservation#274

Merged
anguillanneuf merged 5 commits into
mainfrom
types
Nov 30, 2021
Merged

feat: surface ReservationPath and Reservation#274
anguillanneuf merged 5 commits into
mainfrom
types

Conversation

@anguillanneuf

@anguillanneuf anguillanneuf commented Nov 16, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Surface Reservation and ReservationPath
  • Reorder types
@anguillanneuf anguillanneuf requested review from a team November 16, 2021 17:52
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2021
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Nov 16, 2021
tseaver
tseaver suggested changes Nov 16, 2021
View reviewed changes
Comment thread google/cloud/pubsublite/types/__init__.py Outdated
@anguillanneuf @tseaver
Update google/cloud/pubsublite/types/__init__.py
df9a359 
Co-authored-by: Tres Seaver <tseaver@palladion.com>
@google-cla google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 17, 2021
@dpcollins-google dpcollins-google added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 19, 2021
@dpcollins-google

dpcollins-google commented Nov 19, 2021

Copy link
Copy Markdown
Contributor

Authorizing CLA: not sure why the bot doesn't like tianzi :/
dpcollins-google
dpcollins-google reviewed Nov 19, 2021
View reviewed changes
Comment thread google/cloud/pubsublite/types/__init__.py Outdated
dpcollins-google
dpcollins-google suggested changes Nov 19, 2021
View reviewed changes

@dpcollins-google dpcollins-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment
@google-cla google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 29, 2021
@anguillanneuf anguillanneuf changed the title feat: surface Reservation and ReservationPath in types Nov 29, 2021
@anguillanneuf anguillanneuf changed the title feat: surface ReservationPath in types Nov 29, 2021
@anguillanneuf anguillanneuf added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2021
@google-cla google-cla Bot removed the cla: no This human has *not* signed the Contributor License Agreement. label Nov 30, 2021
@anguillanneuf anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2021
@google-cla google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 30, 2021
@dpcollins-google dpcollins-google added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 30, 2021
@tseaver

tseaver commented Nov 30, 2021

Copy link
Copy Markdown
Contributor

@googlebot I consent.
@anguillanneuf anguillanneuf merged commit eb50503 into main Nov 30, 2021
@anguillanneuf anguillanneuf deleted the types branch November 30, 2021 19:26
This was referenced Nov 30, 2021
Merged
Merged
@release-please release-please Bot mentioned this pull request Jan 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

4 participants

@anguillanneuf @dpcollins-google @tseaver @yoshi-kokoro