samples: regional topics samples#266
Merged
Merged
Conversation
Merged
|
Do you know why all the "Samples - Python 3.X" tests fail? Can you resolve those, after that ping me and I will LGTM |
jiangmichaellll
approved these changes
Jan 13, 2022
Contributor
|
Hi @anguillanneuf, please could you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT SUBMIT until service goes live (early 2022).
DO NOT SUBMIT until we cut a new release of the library that includes #274.
All tests pass using the whitelisted project for now.
Also see googleapis/java-pubsublite#929