Skip to content

chore: Update skaffold base image#8460

Merged
aaron-prindle merged 3 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:update-skaffold-base-image
Feb 23, 2023
Merged

chore: Update skaffold base image#8460
aaron-prindle merged 3 commits into
GoogleContainerTools:mainfrom
ericzzzzzzz:update-skaffold-base-image

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Feb 22, 2023

Copy link
Copy Markdown
Contributor

Fixes: #8418

related: #8418
Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Test Plan

  • build dependencies image docker build \ -f deploy/skaffold/Dockerfile.deps \ -t abc/build_deps:5b53a3d6c20eadaf870bb6f388c95107bbd731e8 \ .
  • change deploy/skaffold/Dockerfile base image to be abc/build_deps:5b53a3d6c20eadaf870bb6f388c95107bbd731e8
  • run cp deploy/skaffold/Dockerfile . to copy dockerfile to working directory
  • build a skaffold builder image docker build -t your_repo:image_name --target builder .
  • docker push your_repo:image_name
  • run docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -e DOCKER_CONFIG=/root/.docker your_repo:image_name make integration-tests to run tests with the new image, we can exit container after seeing a few success.
  • This will get tested when we merge this pr, then the all the integration test will use the new image``
@codecov

codecov Bot commented Feb 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8460 (99c7ad2) into main (290280e) will decrease coverage by 5.27%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8460      +/-   ##
==========================================
- Coverage   70.48%   65.21%   -5.27%     
==========================================
  Files         515      603      +88     
  Lines       23150    29898    +6748     
==========================================
+ Hits        16317    19498    +3181     
- Misses       5776     8924    +3148     
- Partials     1057     1476     +419     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 425 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaron-prindle aaron-prindle merged commit 9847653 into GoogleContainerTools:main Feb 23, 2023
aaron-prindle pushed a commit to aaron-prindle/skaffold that referenced this pull request Mar 1, 2023
* chore: Revert "chore: change skaffold base image (GoogleContainerTools#8433)"

This reverts commit 6b3f673.

* chore: update skaffold base image to ubuntu:20.04

* chore: add noninteractive

(cherry picked from commit 9847653)
aaron-prindle added a commit that referenced this pull request Mar 1, 2023
* chore: upgrade go in dockerfile (#8420)

(cherry picked from commit 6289a4b)

* chore: Update skaffold base image (#8460)

* chore: Revert "chore: change skaffold base image (#8433)"

This reverts commit 6b3f673.

* chore: update skaffold base image to ubuntu:20.04

* chore: add noninteractive

(cherry picked from commit 9847653)

---------

Co-authored-by: ericzzzzzzz <102683393+ericzzzzzzz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants