Skip to content

chore: upgrade go in dockerfile#8420

Merged
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
ericzzzzzzz:go-version-in-docker-deps
Feb 13, 2023
Merged

chore: upgrade go in dockerfile#8420
ericzzzzzzz merged 1 commit into
GoogleContainerTools:mainfrom
ericzzzzzzz:go-version-in-docker-deps

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

related: #8418 (don't close this issue after merge)

Fixes: #nnn
Related: Relevant tracking issues, for context
Merge before/after: Dependent or prerequisite PRs

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

@codecov

codecov Bot commented Feb 8, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8420 (5c2075d) into main (290280e) will decrease coverage by 4.57%.
The diff coverage is 55.02%.

@@            Coverage Diff             @@
##             main    #8420      +/-   ##
==========================================
- Coverage   70.48%   65.91%   -4.57%     
==========================================
  Files         515      605      +90     
  Lines       23150    29834    +6684     
==========================================
+ Hits        16317    19666    +3349     
- Misses       5776     8695    +2919     
- Partials     1057     1473     +416     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 416 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaron-prindle

Copy link
Copy Markdown
Contributor

Not sure if you wanted to merge this as is or do a separate PR to address the ubuntu base image, either way seems fine to me

@ericzzzzzzz

ericzzzzzzz commented Feb 13, 2023

Copy link
Copy Markdown
Contributor Author

Not sure if you wanted to merge this as is or do a separate PR to address the ubuntu base image, either way seems fine to me

ahhh.. I'll create another pr.. just for making the scope correct for each pr :)

@ericzzzzzzz ericzzzzzzz merged commit 6289a4b into GoogleContainerTools:main Feb 13, 2023
aaron-prindle pushed a commit to aaron-prindle/skaffold that referenced this pull request Feb 13, 2023
ericzzzzzzz added a commit to ericzzzzzzz/skaffold that referenced this pull request Feb 28, 2023
ericzzzzzzz added a commit that referenced this pull request Mar 1, 2023
* chore: upgrade go in dockerfile (#8420)

* chore: change ubuntu base image
aaron-prindle pushed a commit to aaron-prindle/skaffold that referenced this pull request Mar 1, 2023
aaron-prindle added a commit that referenced this pull request Mar 1, 2023
* chore: upgrade go in dockerfile (#8420)

(cherry picked from commit 6289a4b)

* chore: Update skaffold base image (#8460)

* chore: Revert "chore: change skaffold base image (#8433)"

This reverts commit 6b3f673.

* chore: update skaffold base image to ubuntu:20.04

* chore: add noninteractive

(cherry picked from commit 9847653)

---------

Co-authored-by: ericzzzzzzz <102683393+ericzzzzzzz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants