Skip to content

chore: release/v1.39.6#8479

Merged
ericzzzzzzz merged 2 commits into
GoogleContainerTools:release/v1.39.6from
ericzzzzzzz:release/v1.39.6
Mar 1, 2023
Merged

chore: release/v1.39.6#8479
ericzzzzzzz merged 2 commits into
GoogleContainerTools:release/v1.39.6from
ericzzzzzzz:release/v1.39.6

Conversation

@ericzzzzzzz

@ericzzzzzzz ericzzzzzzz commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

Description

  • run docker run -it --rm gcr.io/ericz-skaffold/v1skaffold:today gcloud version to verify gcloud version should be 409, this is the version on this branch, the main branch is 414
  • check this image gcr.io/ericz-skaffold/v1skaffold:today for vulns

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

@ericzzzzzzz ericzzzzzzz requested a review from a team as a code owner February 28, 2023 22:08
@ericzzzzzzz ericzzzzzzz requested review from cloud-deploy-bot and removed request for a team February 28, 2023 22:08
@codecov

codecov Bot commented Feb 28, 2023

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (release/v1.39.6@64f6ffd). Click here to learn what that means.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##             release/v1.39.6    #8479   +/-   ##
==================================================
  Coverage                   ?   68.31%           
==================================================
  Files                      ?      563           
  Lines                      ?    26707           
  Branches                   ?        0           
==================================================
  Hits                       ?    18246           
  Misses                     ?     7186           
  Partials                   ?     1275           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz

Copy link
Copy Markdown
Contributor Author

test failing seems an old issue.

@aaron-prindle

aaron-prindle commented Feb 28, 2023

Copy link
Copy Markdown
Contributor

Windows test is a known failure on v1 branch:

TestDockerCLICheckCacheFromArgs

unrelated to the changes here

@aaron-prindle aaron-prindle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericzzzzzzz ericzzzzzzz merged commit e6c2f95 into GoogleContainerTools:release/v1.39.6 Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants