Skip to content

Sign Skills - #62

Open
ohadmo wants to merge 11 commits into
devfrom
omosafi/resign-skills
Open

ohadmo wants to merge 11 commits into
devfrom
omosafi/resign-skills

Conversation

@ohadmo

@ohadmo ohadmo commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo ohadmo self-assigned this Sep 14, 2026
@ohadmo ohadmo changed the title Resign Skills Sep 14, 2026
@ohadmo

ohadmo commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@greptile-apps

greptile-apps Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness, security, or repository-rule findings.

Findings

  1. P2 License terms are missing ▶

Summary

This PR packages and signs five Complexa skills, expands hardware-aware evaluation behavior, stages the required design and target fixtures, updates supporting references and scripts, and regenerates benchmark reports and skill cards.

  • Adds signed skill bundles and refreshed validation evidence.
  • Introduces explicit GPU, CPU-fallback, blocked, and undetermined evaluation branches.
  • Adds fixture-backed design, sweep, and target evaluation scenarios.
  • Corrects the previously missing evaluation fixtures and restores license information in the affected skill cards.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    A[Skill source and references] --> B[Evaluation datasets and fixtures]
    B --> C[Validation and live evaluation]
    C --> D[Benchmark report]
    C --> E[Skill card]
    D --> F[Signed skill bundle]
    E --> F
Loading

Reviews (9) · Last reviewed commit: "Attach NVSkills validation signatures"

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Comment thread skills/complexa-design/evals/evals.json Outdated
Comment thread skills/complexa-target/evals/evals.json Outdated
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
## Owner
NVIDIA <br>

### License/Terms of Use: <br>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 License terms are missing

The regenerated card leaves the License/Terms of Use section empty, although it previously documented the Apache 2.0, CC-BY-4.0, and NVIDIA Open Model License terms. Publishing it this way omits information consumers need to understand usage and attribution obligations. The regenerated skills/complexa-target/skill-card.md has the same empty field.

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: Ohad Mosafi <omosafi@nvidia.com>
@ohadmo

ohadmo commented Sep 19, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

2 similar comments
@ohadmo

ohadmo commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

@ohadmo

ohadmo commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

/nvskills-ci

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants