wslc: add --all-tags to pull for docker parity

[ggarzia-MSFT]

Summary of the Pull Request

Adds the --all-tags / -a flag to wslc pull and wslc image pull. When specified, every tag in the repository is downloaded instead of a single tag.

PR Checklist

• Closes: Link to issue #xxx
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated if needed and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated if needed
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Behavior

1. A reference that already names a tag or digest is rejected. wslc pull ubuntu:22.04 --all-tags fails with tag can't be used with --all-tags/-a rather than silently ignoring one of the two.
2. The Using default tag: latest line is suppressed. because with --all-tags no default tag is applied.
3. The final line prints the repository, not a tagged reference. Docker prints distributionRef.String(), and TagNameOnly is not applied under --all-tags, so docker pull -a ubuntu ends with docker.io/library/ubuntu.

Tests

• 11 command-line parser cases covering --all-tags, -a, both pull and image pull spellings, --all-tags=true, flag-before-positional ordering, and the negative cases --alltags and the case-sensitive -A.
• ImagePullCommand_HasAllTagsArgumentWithDockerAlias unit test.
• New WSLCE2EImagePullTests.cpp with WSLCE2E_Image_Pull_AllTagsListedInHelp, WSLCE2E_Image_Pull_AllTagsRejectsTaggedReference, and WSLCE2E_Image_Pull_AllTagsRejectsDigestReference.

Validation Steps Performed

Full cmake --build . succeeds. wslc image pull --help was run against the local build and lists -a --all-tags Download all tagged images in the repository.

[Copilot]

Pull request overview

Adds Docker-parity support for pulling all tags from an image repository by introducing --all-tags / -a on wslc pull and wslc image pull, wiring it through the CLI → service layer, and covering the new behavior with unit + E2E tests.

Changes:

• Add --all-tags/-a argument for pull commands and enforce “reject tagged/digest reference” + adjusted output behavior in the CLI task.
• Extend the IWSLCSession::PullImage COM method signature to accept an AllTags boolean and plumb it through ImageService.
• Add/extend command-line parser tests, unit tests, and new E2E coverage for the --all-tags behavior and help text.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/windows/WSLCTests.cpp	Updates PullImage calls to match the new COM signature (adds AllTags arg).
test/windows/wslc/WSLCCLICommandUnitTests.cpp	Adds unit test ensuring image pull registers --all-tags with -a.
test/windows/wslc/e2e/WSLCE2EImagePullTests.cpp	New E2E tests for help output and rejecting tag/digest refs under --all-tags.
test/windows/wslc/CommandLineTestCases.h	Adds command-line parsing cases for --all-tags/-a and negative cases.
test/windows/PluginTests.cpp	Updates PullImage call to match the new COM signature.
src/windows/wslcsession/WSLCSession.h	Adds BOOL AllTags parameter to WSLCSession::PullImage.
src/windows/wslcsession/WSLCSession.cpp	Implements AllTags behavior by omitting tag defaulting when requested; updates compat call site to pass FALSE.
src/windows/wslc/tasks/ImageTasks.cpp	Adds CLI flag handling, validation (reject tag/digest), default-tag output suppression, and final-line output adjustment.
src/windows/wslc/services/ImageService.h	Extends ImageService::Pull signature to accept allTags (default false).
src/windows/wslc/services/ImageService.cpp	Plumbs allTags into the COM PullImage call.
src/windows/wslc/commands/ImagePullCommand.cpp	Registers ArgType::AllTags for image pull.
src/windows/wslc/arguments/ArgumentDefinitions.h	Defines AllTags argument metadata (--all-tags, alias -a).
src/windows/service/inc/wslc.idl	Updates IWSLCSession::PullImage signature to include [in] BOOL AllTags.
localization/strings/en-US/Resources.resw	Adds localized strings for the new arg description and the new error message.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/windows/wslcsession/WSLCSession.cpp:945

• When AllTags is TRUE, this method currently drops any existing tag/digest from the input reference (tagOrDigest.reset()) instead of rejecting the invalid combination. That means API callers can pass e.g. "ubuntu:22.04" with AllTags=TRUE and the tag will be silently ignored, contradicting the CLI behavior and the documented intent for --all-tags.

    // Omitting the tag makes the daemon pull every tag in the repository.
    if (AllTags)
    {
        tagOrDigest.reset();
    }

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

[Copilot]

🔵 Needs a closer look

The session-layer PullImage currently allows AllTags combined with a tag/digest by silently dropping it, contradicting the documented “reject tagged/digest refs” behavior and risking unintended “pull all tags” behavior for non-CLI callers.

Review details

Suppressed comments (1)

src/windows/wslcsession/WSLCSession.cpp:942

• When AllTags is TRUE, the session currently clears any parsed tag/digest and proceeds, so a caller can pass a tagged or digested reference together with AllTags and end up pulling all tags instead of getting the documented E_INVALIDARG. Consider rejecting this combination in the session layer as well (defense-in-depth vs. other callers bypassing CLI validation).

    if (AllTags)
    {
        tagOrDigest.reset();
    }

• Files reviewed: 14/14 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🟡 Changes recommended

The localization lock token for the new error string should be corrected and the new --all-tags behavior lacks a positive E2E validation that it actually pulls multiple tags from a registry.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 14/14 changed files
• Comments generated: 2
• Review effort level: Lite

[Copilot]

🟡 Changes recommended

The session-layer implementation does not currently appear to enable “pull all tags” at the Docker Engine API level (missing the all-tags query option), so the core feature may not function as intended.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 14/14 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

The current session-side implementation does not send an explicit empty tag= when AllTags is set, so the underlying pull request is unlikely to actually pull all tags and will break the new multi-tag e2e scenario.

Review details

Suppressed comments (1)

src/windows/wslcsession/WSLCSession.cpp:938

• --all-tags currently just leaves tagOrDigest unset, which means DockerHTTPClient omits the tag query parameter entirely. The Docker Engine API treats a missing tag as the default (typically latest), so this won’t actually pull every tag and will fail for repositories that don’t publish latest (e.g. the new e2e test’s v1/v2-only repo). To request all tags, the pull request should send an explicit empty tag parameter (tag=) when AllTags is set.

    // Omitting the tag makes the daemon pull every tag in the repository. A reference that names a
    // tag or digest is rejected rather than silently ignored.
    RETURN_HR_IF(E_INVALIDARG, AllTags && tagOrDigest.has_value());

    if (!AllTags && !tagOrDigest.has_value())

• Files reviewed: 14/14 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

The all-tags path currently pulls only latest, and explicit default-tag suppression coverage is missing.

Review details

Suppressed comments (2)

src/windows/wslc/tasks/ImageTasks.cpp:278

• This branch suppresses the default-tag message for --all-tags, but the new pull E2E coverage never asserts that behavior: WSLCE2E_Image_Pull_AllTagsDownloadsEveryTag only checks that the repository appears somewhere in stdout. A regression that prints Using default tag: latest would still pass; add an explicit negative stdout assertion for the all-tags pull, as the push tests do.

    if (!quiet && !allTags && reference.Format == EnumReferenceFormatNone)

src/windows/wslcsession/WSLCSession.cpp:953

• Leaving tagOrDigest empty does not make the Docker /images/create request an all-tags request: the request builder simply omits tag, and the Docker pull API treats an omitted tag as latest. Consequently this path still downloads only latest; enumerate the repository's tags and issue a tagged pull for each one (or add an explicit backend operation) before reporting success.

    if (!AllTags && !tagOrDigest.has_value())
    {
        tagOrDigest = "latest";
    }

• Files reviewed: 13/13 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Md Jahangir Bokhs (jahangirbokhs9)]

jahangirbokhs72@outlook.com

[Copilot]

🔵 Needs a closer look

Unresolved all-tags behavior, duplicate notifications, and E2E test issues remain.

Review details

Suppressed comments (5)

src/windows/wslc/services/ImageService.cpp:389

• The new flag is forwarded to WSLCSession, but the underlying DockerHTTPClient::PullImage still only omits the tag parameter; it never sends Docker's allTags=true query parameter. Docker treats an omitted tag as latest, so --all-tags will not download repositories containing only non-latest tags (as in the new v1/v2 E2E setup). Thread the flag through the HTTP client and set allTags on the request.

    THROW_IF_FAILED(session.Get()->PullImage(image.c_str(), auth.c_str(), allTags ? TRUE : FALSE, callback, &warningCallback));

src/windows/wslcsession/WSLCSession.cpp:926

• ListImages returns a separate entry for each repository tag, so two tags pointing to the same image ID make this loop invoke OnImageCreated twice with the same ID. That contradicts the stated one-notification-per-distinct-image behavior and sends duplicate plugin callbacks; deduplicate image.Id before notifying.

    for (const auto& image : m_runtime.Docker().ListImages(false, false, {{"reference", {Repository.Name}}}))
    {
        OnImageCreated(image.Id);
    }

test/windows/wslc/e2e/WSLCE2EImagePullTests.cpp:61

• Please use a unique registry port here. StartLocalRegistry publishes plain HTTP registries on the host, and WSLCE2EImagePushTests.cpp:86 already uses 15006; parallel TAEF runs can make one registry fail to bind before this test exercises pull.

            auto [registryContainer, registryAddress] = StartLocalRegistry(*session, "", "", 15006);

test/windows/wslc/e2e/WSLCE2EImagePullTests.cpp:84

• The PR promises that --all-tags suppresses the Using default tag: latest line, but this success path only checks that the repository line exists. Add a negative assertion here so a regression in the new !allTags condition is covered.

            VERIFY_IS_TRUE(result.StdoutContainsLine(repository));

test/windows/wslc/e2e/WSLCE2EImagePullTests.cpp:3

• This new source file uses the legacy block copyright header. New files in this repository use the single-line (C) Microsoft Corporation form, for example WSLCE2EContainerCpTests.cpp:1; please use that format here.

/*++

Copyright (c) Microsoft. All rights reserved.

• Files reviewed: 13/13 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🟡 Changes recommended

An unresolved critical issue prevents --all-tags from reaching the Docker Engine request.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (1)

test/windows/wslc/e2e/WSLCE2EImagePullTests.cpp:83

• This success-path test is the only coverage for the new pull-specific default-tag suppression, but it never asserts that the Using default tag: latest line is absent. A regression in the !allTags guard would still pass; add the negative output assertion here.

            result.Verify({.Stderr = L"", .ExitCode = 0});

• Files reviewed: 13/13 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

All-tags pulling must enumerate and download every tag, and the E2E test must clean up v3.

Review details

Suppressed comments (2)

src/windows/wslcsession/WSLCSession.cpp:994

• Passing a null tagOrDigest only omits the tag query parameter in DockerHTTPClient::PullImage; it does not enumerate registry tags. The Engine /images/create endpoint defaults an omitted tag to latest, so this single request cannot implement --all-tags and the v1/v2/v3 E2E case will pull only one tag. Discover the repository's tags and issue a pull for each while preserving the digest collection/notification behavior.

    std::vector<std::string> pulledDigests;
    StreamImageOperation(*requestContext, Image, "Pull", ProgressCallback, AllTags ? &pulledDigests : nullptr);

test/windows/wslc/e2e/WSLCE2EImagePullTests.cpp:70

• This test creates a third local tag (v3) at lines 72-75, but the cleanup deletes only v1 and v2. Because it uses the shared default session, repository:v3 remains in the local image store after the test and can affect later tests or repeated runs; include the third tag in the cleanup.

            auto cleanup = wil::scope_exit([&]() {
                RunWslc(std::format(L"image delete --force {}", firstTag));
                RunWslc(std::format(L"image delete --force {}", secondTag));
            });

• Files reviewed: 13/13 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Blue (OneBlue)]

LGTM. One minor comment (feel free to address in a followup)

[Copilot]

🟡 Changes recommended

The all-tags request must explicitly set Docker’s all=true option before approval.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (1)

src/windows/wslc/tasks/ImageTasks.cpp:278

• The new contract requires --all-tags to suppress Using default tag: latest, but the successful pull test only checks exit status, stderr, and the final repository line, so a regression that prints the default-tag notice would still pass. Add an assertion that stdout does not contain the default-tag message for this path.

    if (!quiet && !allTags && reference.Format == EnumReferenceFormatNone)

• Files reviewed: 13/13 changed files
• Comments generated: 1
• Review effort level: Lite