wslc: add --all-tags to push for docker parity

[ggarzia-MSFT]

Summary of the Pull Request

Adds the --all-tags / -a flag to wslc push and wslc image push for Docker CLI parity, and aligns the default (no-flag) push behavior with docker push.

PR Checklist

• Closes: Link to issue #xxx
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated if needed and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated if needed
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Behavior change worth calling out

At the Engine API level, "push all tags" is expressed by omitting the tag query parameter on POST /images/{name}/push — the same thing the moby client does (if !options.All { query.Set("tag", tag) }).

WSLCSession::PushImage previously forwarded the parsed tag verbatim, so an untagged reference such as wslc push myrepo/img already omitted tag and pushed every tag. That means simply adding --all-tags would have made the flag a no-op relative to the default.

This PR therefore also makes the untagged case default to latest, matching docker push and matching what wslc pull already does. After this change:

Command	Pushes
wslc push myrepo/img	myrepo/img:latest (and prints Using default tag: latest)
wslc push myrepo/img:v1	myrepo/img:v1
wslc push myrepo/img --all-tags	every tag in myrepo/img
wslc push myrepo/img:v1 --all-tags	error: tag can't be used with --all-tags/-a

Tests

• 11 command-line parser cases covering --all-tags, -a, both push and image push spellings, --all-tags=true, flag-before-positional ordering, and the negative cases --alltags and the case-sensitive -A.
• ImagePushCommand_HasAllTagsArgumentWithDockerAlias unit test.
• New WSLCE2EImagePushTests.cpp with WSLCE2E_Image_Push_AllTagsListedInHelp, WSLCE2E_Image_Push_AllTagsRejectsTaggedReference, and WSLCE2E_Image_Push_AllTagsRejectsDigestReference.

Note for reviewers

The companion pull --all-tags PR introduces the same ArgType::AllTags entry and an equivalent tag can't be used with --all-tags/-a string under a WSLCCLI_PullAllTagsWithTagError key. Whichever lands second should reuse the neutral WSLCCLI_AllTagsWithTagError key added here rather than keeping both.

Validation Steps Performed

Full cmake --build . succeeds. wslc image push --help was run against the local build and lists -a --all-tags Push all tags of an image to the repository. Automated coverage above; CI runs the test suite.

[Copilot]

🟡 Changes recommended

WSLCSession::PushImage currently allows AllTags=TRUE with a tagged/digest reference by silently pushing all tags, diverging from the CLI/docker-parity behavior that rejects this combination.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds Docker-parity support for --all-tags/-a on wslc push / wslc image push, and changes default push semantics for name-only references to push :latest (instead of implicitly pushing all tags), with updated localization and test coverage.

Changes:

• Add --all-tags/-a CLI flag wiring for push, plus user-facing help/error strings.
• Update IWSLCSession::PushImage/WSLCSession::PushImage to accept an AllTags boolean and adjust tag defaulting behavior.
• Add/extend unit and E2E tests covering parsing, help text, and invalid combinations.

File summaries

File	Description
test/windows/WSLCTests.cpp	Updates PushImage test calls for new AllTags parameter.
test/windows/wslc/WSLCCLICommandUnitTests.cpp	Adds unit coverage verifying --all-tags is registered with -a alias.
test/windows/wslc/e2e/WSLCE2EImagePushTests.cpp	New E2E tests for help text and invalid --all-tags combinations.
test/windows/wslc/CommandLineTestCases.h	Adds command-line parser test cases for push + --all-tags/-a.
test/windows/PluginTests.cpp	Updates PushImage call signature for plugin tests.
src/windows/wslcsession/WSLCSession.h	Extends PushImage COM method signature with AllTags.
src/windows/wslcsession/WSLCSession.cpp	Implements AllTags behavior and default tag handling in PushImage.
src/windows/wslc/tasks/ImageTasks.cpp	Adds CLI-side --all-tags parsing, validation, and default-tag messaging.
src/windows/wslc/services/ImageService.h	Extends ImageService::Push signature to accept allTags.
src/windows/wslc/services/ImageService.cpp	Forwards allTags into session PushImage call.
src/windows/wslc/commands/ImagePushCommand.cpp	Registers --all-tags argument + push-specific description.
src/windows/wslc/arguments/ArgumentDefinitions.h	Adds ArgType::AllTags to argument definitions.
src/windows/service/inc/wslc.idl	Updates IWSLCSession::PushImage signature in IDL.
localization/strings/en-US/Resources.resw	Adds new localized strings for --all-tags and the tag+all-tags error.

Review details

• Files reviewed: 14/14 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

The session-layer AllTags implementation can silently override an explicitly provided tag/digest (instead of rejecting it), and the new default-tag push behavior lacks dedicated e2e coverage.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

src/windows/wslcsession/WSLCSession.cpp:2126

• When AllTags is TRUE, this currently clears any explicitly provided tag/digest and pushes every tag in the repository. That makes a tagged reference like "repo:tag" behave very differently (and potentially unexpectedly) instead of being rejected like the CLI does.

    // Omitting the tag makes the daemon push every tag in the repository.
    if (AllTags)
    {
        tagOrDigest.reset();
    }

• Files reviewed: 14/14 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

🟡 Changes recommended

It includes a repository-inappropriate local script (merge-probe.ps1) and the PushImage signature change is not reflected in the SDK wrapper call site (e.g., src/windows/WslcSDK/wslcsdk.cpp), which would break compilation once headers regenerate.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 15/15 changed files
• Comments generated: 2
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

The new “name-only push defaults to :latest” behavior is not currently covered by a push-specific e2e test, leaving a regression risk for the main behavior change.

Review details

Suppressed comments (1)

test/windows/wslc/e2e/WSLCE2EImagePushTests.cpp:48

• The PR changes push <name> (no tag) to default to :latest and print Using default tag: latest, but there’s no e2e coverage for that push-specific behavior (only pull has WSLCE2E_Image_Pull_NameOnlyDefaultsTag). Adding a small test here would prevent regressions in the new default-tag logic.

    WSLC_TEST_METHOD(WSLCE2E_Image_Push_AllTagsRejectsDigestReference)
    {
        const auto result =
            RunWslc(L"image push debian@sha256:0000000000000000000000000000000000000000000000000000000000000000 -a");
        result.Verify({.Stdout = L"", .ExitCode = 1});
        VERIFY_IS_TRUE(result.StderrContainsSubstring(Localization::WSLCCLI_AllTagsWithTagError()));
    }

• Files reviewed: 14/14 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🟡 Changes recommended

It introduces new user-facing validation paths and behavior changes that need a service-layer user error message and additional e2e coverage for the new “name-only defaults to latest” push behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

test/windows/wslc/e2e/WSLCE2EImagePushTests.cpp:50

• The PR changes push behavior so a name-only reference defaults to the "latest" tag and prints "Using default tag: latest". There are e2e tests for the pull default-tag behavior, but there isn’t an equivalent push coverage here; adding it would prevent regressions in the new defaulting + output behavior.

    WSLC_TEST_METHOD(WSLCE2E_Image_Push_AllTagsRejectsDigestReference)
    {
        const auto result =
            RunWslc(L"image push debian@sha256:0000000000000000000000000000000000000000000000000000000000000000 -a");
        result.Verify({.Stdout = L"", .ExitCode = 1});
        VERIFY_IS_TRUE(result.StderrContainsSubstring(Localization::WSLCCLI_AllTagsWithTagError()));
    }
};
} // namespace WSLCE2ETests

• Files reviewed: 14/14 changed files
• Comments generated: 2
• Review effort level: Lite

[Copilot]

🟡 Changes recommended

The user-visible default-tag behavior change for wslc push is not directly asserted by E2E tests, which increases regression risk.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

src/windows/wslc/tasks/ImageTasks.cpp:310

• push is now using Localization::WSLCCLI_PullUsingDefaultTag(...) for its user-facing output. Since this string is no longer pull-specific, consider introducing a neutral localization key (e.g., WSLCCLI_UsingDefaultTag) and using it for both pull and push to avoid misleading key names and future localization context confusion.

    {
        context.Terminal.Output(L"{}\n", Localization::WSLCCLI_PullUsingDefaultTag(L"latest"));

• Files reviewed: 14/14 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

🟡 Changes recommended

The WSLCCompat/SDK-facing PushImage path currently loses the ability to trigger “push all tags” semantics (name-only reference) because it hard-codes AllTags=FALSE, which is a potentially breaking behavioral regression for compat callers.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 14/14 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

🟡 Changes recommended

The new WSLCCLI_AllTagsWithTagError message is used for both tag and digest references but currently only mentions “tag”, which is misleading for digest inputs.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

src/windows/wslc/tasks/ImageTasks.cpp:309

• Push is printing the “Using default tag” message via Localization::WSLCCLI_PullUsingDefaultTag(), which makes the localization key/name misleading now that it’s shared by both pull and push. Consider introducing a neutral localization key (e.g. WSLCCLI_UsingDefaultTag) and using it from both pull and push to avoid future confusion.

    // For a name-only reference the tag defaults to "latest", reported on stdout before contacting the registry.
    if (!allTags && reference.Format == EnumReferenceFormatNone)
    {
        context.Terminal.Output(L"{}\n", Localization::WSLCCLI_PullUsingDefaultTag(L"latest"));
    }

• Files reviewed: 14/14 changed files
• Comments generated: 1
• Review effort level: Lite

[Pooja Trivedi (ptrivedi)]

few minor comments, lgtm otherwise

[Copilot]

🟡 Changes recommended

It introduces at least one concrete correctness/reliability issue (port reuse in E2E tests) and a likely breaking behavior change for the WSLCCompat/SDK push surface that currently has no way to request “push all tags.”

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

src/windows/wslcsession/WSLCSession.cpp:3685

• WSLCCompat PushImage now always forwards AllTags=FALSE, which removes the previous ability for compat/SDK callers to push all tags by passing a name-only reference (and changes behavior from “push all tags” to defaulting to “latest”). Since WslcPushImageOptions has no all-tags field, this is a breaking behavior change for the SDK surface; consider preserving legacy behavior for WSLCCompat by forwarding AllTags=TRUE when the input has no explicit tag/digest.

{
    const auto progress = apicompat::Convert(ProgressCallback);
    const auto warning = apicompat::Convert(WarningCallback);

    return PushImage(Image, RegistryAuthenticationInformation, FALSE, progress.Get(), warning.Get());

• Files reviewed: 14/14 changed files
• Comments generated: 1
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

The new localized error string that includes “-a” should also lock the short flag to prevent accidental translation of the CLI switch.

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

localization/strings/en-US/Resources.resw:2988

• The error string includes the short flag "-a" ("--all-tags/-a"), but the localization comment only locks the long flag. To prevent translators from inadvertently changing the short flag, add a {Locked="-a"} token to the comment as well.

• Files reviewed: 14/14 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🟢 Approval recommended

The flag and behavioral changes are consistently plumbed end-to-end (CLI→service), with updated callers and solid unit/E2E coverage for the new and changed behaviors.

Review details

• Files reviewed: 14/14 changed files
• Comments generated: 0 new
• Review effort level: Lite

[Copilot]

🔵 Needs a closer look

The newly added user-facing localization strings for --all-tags include ambiguous/misleading wording that should be clarified before merge.

Review details

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

localization/strings/en-US/Resources.resw:2984

• WSLCCLI_AllTagsArgDescription is the default help text for the ArgType::AllTags flag (ArgumentDefinitions.h). The current text is pull-specific ("Download"), which is easy to accidentally surface in push/help output if a command forgets to override the description; consider making this string neutral so it’s correct for both pull and push contexts.
  localization/strings/en-US/Resources.resw:2987
• The error message "tag can't be used with --all-tags/-a" is ambiguous (there is no "tag" option; this refers to a tagged/digested image reference) and also inconsistent with other CLI errors that use clearer sentence-case phrasing (e.g., "cannot be used"). Rewording to explicitly mention tagged/digested references would make it clearer for users.

• Files reviewed: 14/14 changed files
• Comments generated: 0 new
• Review effort level: Lite

[ggarzia-MSFT]

few minor comments, lgtm otherwise

Addressed your comments

[Pooja Trivedi (ptrivedi)]

🔵 Needs a closer look

The newly added user-facing localization strings for --all-tags include ambiguous/misleading wording that should be clarified before merge.

Review details

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

localization/strings/en-US/Resources.resw:2984

• WSLCCLI_AllTagsArgDescription is the default help text for the ArgType::AllTags flag (ArgumentDefinitions.h). The current text is pull-specific ("Download"), which is easy to accidentally surface in push/help output if a command forgets to override the description; consider making this string neutral so it’s correct for both pull and push contexts.
  localization/strings/en-US/Resources.resw:2987

• The error message "tag can't be used with --all-tags/-a" is ambiguous (there is no "tag" option; this refers to a tagged/digested image reference) and also inconsistent with other CLI errors that use clearer sentence-case phrasing (e.g., "cannot be used"). Rewording to explicitly mention tagged/digested references would make it clearer for users.

• Files reviewed: 14/14 changed files

• Comments generated: 0 new

• Review effort level: Lite

Would be good to address these or provide an explanation of why later/not

[ggarzia-MSFT]

🔵 Needs a closer look

The newly added user-facing localization strings for --all-tags include ambiguous/misleading wording that should be clarified before merge.
Review details

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.
localization/strings/en-US/Resources.resw:2984

• WSLCCLI_AllTagsArgDescription is the default help text for the ArgType::AllTags flag (ArgumentDefinitions.h). The current text is pull-specific ("Download"), which is easy to accidentally surface in push/help output if a command forgets to override the description; consider making this string neutral so it’s correct for both pull and push contexts.
  localization/strings/en-US/Resources.resw:2987
• The error message "tag can't be used with --all-tags/-a" is ambiguous (there is no "tag" option; this refers to a tagged/digested image reference) and also inconsistent with other CLI errors that use clearer sentence-case phrasing (e.g., "cannot be used"). Rewording to explicitly mention tagged/digested references would make it clearer for users.
• Files reviewed: 14/14 changed files
• Comments generated: 0 new
• Review effort level: Lite

Would be good to address these or provide an explanation of why later/not

The first comment is factually wrong. The description is overridden at ImagePushCommand.cpp:31

The error message in the second comment is consistent with docker.

[Blue (OneBlue)]

LGTM, minor comments

[Blue (OneBlue)]

Download is a bit misleading since this applies to push and pull. Maybe we could just edit to Download or upload all tagged images in the repository. ?

[ggarzia-MSFT]

This description is overridden at ImagePushCommand.cpp:31

[Blue (OneBlue)]

Same feedback as the pull version: I recommend using flags for boolean switches in the COM API, but not a blocker for this change

[ggarzia-MSFT]

Will make a follow up PR for this and pull