Skip to content

[data] Allow configuring DefaultClusterAutoscalerV2 thresholds via en…#60133

Merged
bveeramani merged 3 commits into
ray-project:masterfrom
rushikeshadhav:data/default-cluster-autoscaler-v2-env-v2
Jan 19, 2026
Merged

[data] Allow configuring DefaultClusterAutoscalerV2 thresholds via en…#60133
bveeramani merged 3 commits into
ray-project:masterfrom
rushikeshadhav:data/default-cluster-autoscaler-v2-env-v2

Conversation

@rushikeshadhav

Copy link
Copy Markdown
Contributor

Description

Make DefaultClusterAutoscalerV2 knobs configurable via environment variables

Related issues

Closes #60004

@rushikeshadhav rushikeshadhav requested a review from a team as a code owner January 14, 2026 06:47

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable improvement by making several key autoscaling thresholds configurable via environment variables in DefaultClusterAutoscalerV2. This enhances the flexibility and deployability of the autoscaler by allowing dynamic adjustment of its behavior without code changes. The overall approach of using env_float and env_integer functions for configuration is sound. However, a critical issue was identified regarding the availability of the env_float function.

Comment thread python/ray/data/_internal/cluster_autoscaler/default_cluster_autoscaler_v2.py Outdated
Comment thread python/ray/data/_internal/cluster_autoscaler/default_cluster_autoscaler_v2.py Outdated
@bveeramani

Copy link
Copy Markdown
Member

Good to merge after CI passes and import is fixed

@bveeramani

Copy link
Copy Markdown
Member

Hey @rushikeshadhav , any update on this?

@rushikeshadhav rushikeshadhav force-pushed the data/default-cluster-autoscaler-v2-env-v2 branch 2 times, most recently from 09e0028 to 51a20e0 Compare January 16, 2026 07:13
…v vars

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
@rushikeshadhav rushikeshadhav force-pushed the data/default-cluster-autoscaler-v2-env-v2 branch from 51a20e0 to 50f43f4 Compare January 16, 2026 07:14
@rushikeshadhav

Copy link
Copy Markdown
Contributor Author

Hey @rushikeshadhav , any update on this?

I have made the required changes, can you please check?

@bveeramani bveeramani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@bveeramani bveeramani enabled auto-merge (squash) January 19, 2026 08:21
@github-actions github-actions Bot added the go add ONLY when ready to merge, run all tests label Jan 19, 2026
@bveeramani bveeramani merged commit 0bf74f2 into ray-project:master Jan 19, 2026
8 checks passed
zzchun pushed a commit to antgroup/ant-ray that referenced this pull request Jan 29, 2026
ray-project#60133)

## Description
> Make DefaultClusterAutoscalerV2 knobs configurable via environment
variables

## Related issues
> Closes ray-project#60004

---------

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
zzchun pushed a commit to antgroup/ant-ray that referenced this pull request Feb 5, 2026
ray-project#60133)

## Description
> Make DefaultClusterAutoscalerV2 knobs configurable via environment
variables

## Related issues
> Closes ray-project#60004

---------

Signed-off-by: Rushikesh Adhav <adhavrushikesh6@gmail.com>
Co-authored-by: Balaji Veeramani <balaji@anyscale.com>
zzchun added a commit to antgroup/ant-ray that referenced this pull request Apr 15, 2026
aa640334e16 # Add util package
c535e50e365 # [Data] - Add support for callable classes for UDFExpr (ray-project#56725)
0266765ec39 # [Data] Remove constructor from ClusterAutoscaler base class (ray-project#59733)
03416b2e69f # [Data] DefaultAutoscalerV2 doesn't scale nodes from zero (ray-project#59896)
207295e23db # [Data] Introduce seams to DefaultAutoscaler2 to make it more testable (ray-project#59933)
c5eceb4ce7a # [Data] DefaultClusterAutoscalerV2 raises KeyError: 'CPU' Fix (ray-project#60208)
0bb15c93e5c # [data] Allow configuring DefaultClusterAutoscalerV2 thresholds via en… (ray-project#60133)
e52695c23df # [Data] Fix autoscaler to respect user-configured resource limits (ray-project#60283)
15c929bbc21 # [Data] Reorganize sections of `DefaultAutoscalerV2` constructor (ray-project#60347)
b5ffc068613 # [Data] Fix autoscaler to request previous allocation instead of empty resources when not scaling up (ray-project#60321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community data Ray Data-related issues go add ONLY when ready to merge, run all tests

2 participants