[Data] Fix autoscaler to request previous allocation instead of empty resources when not scaling up#60321
Merged
bveeramani merged 9 commits intoJan 23, 2026
Conversation
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
bveeramani
approved these changes
Jan 20, 2026
bveeramani
approved these changes
Jan 20, 2026
| ) | ||
|
|
||
| # Initialization should send [] | ||
| _send_resource_request.assert_called_with([]) |
Member
There was a problem hiding this comment.
As a general practice, I think we should avoid testing against implementation details, but I think it's okay in this case if there's not a clear alternative
Contributor
Author
There was a problem hiding this comment.
I refactored the test to prevent mocking the _send_resource_request
ray-gardener
Bot
added
data
![cursor[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu>
bveeramani
approved these changes
Jan 23, 2026
zzchun
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Jan 29, 2026
… resources when not scaling up (ray-project#60321) ## Description When the DefaultAutoscalerV2 decides not to scale up (e.g., utilization is low), it currently sends an empty resource request ([]) to the autoscaling coordinator. This should be changed to request the previous allocation instead, preserving the dataset's current resource footprint. ## Related issues Closes ray-project#60191 ## Additional information - Send current resources rather than [] when not scale up - Add test --------- Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu>
zzchun
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Feb 5, 2026
… resources when not scaling up (ray-project#60321) ## Description When the DefaultAutoscalerV2 decides not to scale up (e.g., utilization is low), it currently sends an empty resource request ([]) to the autoscaling coordinator. This should be changed to request the previous allocation instead, preserving the dataset's current resource footprint. ## Related issues Closes ray-project#60191 ## Additional information - Send current resources rather than [] when not scale up - Add test --------- Signed-off-by: machichima <nary12321@gmail.com> Signed-off-by: Balaji Veeramani <bveeramani@berkeley.edu> Co-authored-by: Balaji Veeramani <balaji@anyscale.com> Co-authored-by: Balaji Veeramani <bveeramani@berkeley.edu>
zzchun
added a commit
to antgroup/ant-ray
that referenced
this pull request
Apr 15, 2026
aa640334e16 # Add util package c535e50e365 # [Data] - Add support for callable classes for UDFExpr (ray-project#56725) 0266765ec39 # [Data] Remove constructor from ClusterAutoscaler base class (ray-project#59733) 03416b2e69f # [Data] DefaultAutoscalerV2 doesn't scale nodes from zero (ray-project#59896) 207295e23db # [Data] Introduce seams to DefaultAutoscaler2 to make it more testable (ray-project#59933) c5eceb4ce7a # [Data] DefaultClusterAutoscalerV2 raises KeyError: 'CPU' Fix (ray-project#60208) 0bb15c93e5c # [data] Allow configuring DefaultClusterAutoscalerV2 thresholds via en… (ray-project#60133) e52695c23df # [Data] Fix autoscaler to respect user-configured resource limits (ray-project#60283) 15c929bbc21 # [Data] Reorganize sections of `DefaultAutoscalerV2` constructor (ray-project#60347) b5ffc068613 # [Data] Fix autoscaler to request previous allocation instead of empty resources when not scaling up (ray-project#60321)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the DefaultAutoscalerV2 decides not to scale up (e.g., utilization is low), it currently sends an empty resource request ([]) to the autoscaling coordinator. This should be changed to request the previous allocation instead, preserving the dataset's current resource footprint.
Related issues
Closes #60191
Additional information