Skip to content

Add Zvec Agent - #3574

Draft
Matts966 wants to merge 2 commits into
feature/grpc/common-any-argsfrom
feature/agent/zvec-any-options
Draft

Matts966 wants to merge 2 commits into
feature/grpc/common-any-argsfrom
feature/agent/zvec-any-options

Conversation

@Matts966

@Matts966 Matts966 commented Jul 29, 2026 •

Copy link
Copy Markdown
Member

Summary

  • add the Rust ZVec agent backend and wire it through the agent handlers
  • define ZVec document and hybrid-search protobuf messages on top of the shared Any interface from feat/apis: add algorithm-specific payload options #3589
  • add Helm, Docker, workflow, and E2E configuration for the ZVec agent
  • rebase onto the latest feature/grpc/common-any-args, which is rebased onto main

Verification

  • make proto/all (Buf generation succeeded; repository replacements were applied in smaller batches because macOS xargs exceeded its command-line limit)
  • make test/rust/zvec: 2 passed
  • RUST_TEST_THREADS=1 make RUST_AGENT_FEATURES=zvec test/rust/agent: 7 passed
  • make license
  • added coverage for selecting ZVec options when unrelated Any entries are present

Stacked PR

Base branch: feature/grpc/common-any-args (#3589).

@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vdaas-ci

Copy link
Copy Markdown
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test
@codecov

codecov Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 9.85626% with 439 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/grpc/common-any-args@22bac3a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/agent/core/zvec/service/service.go 0.00% 220 Missing ⚠️
pkg/agent/core/zvec/handler/grpc/handler.go 24.16% 105 Missing and 8 partials ⚠️
pkg/agent/core/zvec/router/router.go 0.00% 40 Missing ⚠️
pkg/agent/core/zvec/handler/rest/handler.go 0.00% 30 Missing ⚠️
pkg/agent/core/zvec/config/config.go 0.00% 24 Missing ⚠️
pkg/agent/core/zvec/router/option.go 0.00% 9 Missing ⚠️
pkg/agent/core/zvec/handler/rest/option.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##             feature/grpc/common-any-args    #3574   +/-   ##
===============================================================
  Coverage                                ?   31.61%           
===============================================================
  Files                                   ?      588           
  Lines                                   ?    50421           
  Branches                                ?        0           
===============================================================
  Hits                                    ?    15939           
  Misses                                  ?    33456           
  Partials                                ?     1026           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Deploying vald with  Cloudflare Pages  Cloudflare Pages

Latest commit: ff6e28c
Status: ✅  Deploy successful!
Preview URL: https://6b78fa8d.vald.pages.dev
Branch Preview URL: https://feature-agent-zvec-any-optio.vald.pages.dev

View logs

@Matts966
Matts966 changed the base branch from main to codex/grpc-common-zvec-interface August 5, 2026 03:09
@Matts966
Matts966 changed the base branch from feature/grpc-common-zvec-interface to feature/grpc/common-any-args August 5, 2026 04:32
@Matts966

Copy link
Copy Markdown
Member Author

/format

@vdaas-ci

Copy link
Copy Markdown
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by Matts966.

@Matts966
Matts966 force-pushed the feature/agent/zvec-any-options branch from f6abe9f to 6d2092a Compare August 13, 2026 06:19
@Matts966
Matts966 force-pushed the feature/agent/zvec-any-options branch from 6d2092a to 7ee3a58 Compare August 18, 2026 03:59
@Matts966
Matts966 force-pushed the feature/agent/zvec-any-options branch from 7ee3a58 to 2b0d1c0 Compare August 18, 2026 04:15
@Matts966
Matts966 force-pushed the feature/agent/zvec-any-options branch from 2b0d1c0 to 7445522 Compare August 19, 2026 05:49

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] reported by reviewdog 🐶
Magic number: 14, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 15, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 16, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 17, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 18, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 19, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 20, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 21, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 22, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 23, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 24, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 25, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 26, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 27, in detected (mnd)


🚫 [golangci] reported by reviewdog 🐶
Magic number: 28, in detected (mnd)

@@ -22889,7 +24372,8 @@ func (m *Object_VectorRequest) UnmarshalVT(dAtA []byte) error {
}
return nil
}
func (m *Object_Distance) UnmarshalVT(dAtA []byte) error {

func (m *Remove_MultiRequest) UnmarshalVT(dAtA []byte) error {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
24376-24546 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:31703-31873 (dupl)

@@ -24685,7 +25663,8 @@ func (m *Object_Locations) UnmarshalVT(dAtA []byte) error {
}
return nil
}
func (m *Object_List_Request) UnmarshalVT(dAtA []byte) error {

func (m *Object_Timestamp) UnmarshalVT(dAtA []byte) error {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
25667-25768 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:31072-31173 (dupl)

@@ -28008,7 +31068,8 @@ func (m *Info_ResourceStats) UnmarshalVT(dAtA []byte) error {
}
return nil
}
func (m *Info_CgroupStats) UnmarshalVT(dAtA []byte) error {

func (m *Info_ServicePort) UnmarshalVT(dAtA []byte) error {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
31072-31173 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:32097-32198 (dupl)

return nil
}

func (m *Info_Pods) UnmarshalVT(dAtA []byte) error {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
31703-31873 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:31789-31959 (dupl)

@@ -28661,7 +31785,8 @@ func (m *Info_Node) UnmarshalVT(dAtA []byte) error {
}
return nil
}
func (m *Info_Service) UnmarshalVT(dAtA []byte) error {

func (m *Info_Nodes) UnmarshalVT(dAtA []byte) error {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
31789-31959 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:37483-37653 (dupl)

break
}
}
case 9:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Magic number: 9, in detected (mnd)

break
}
}
case 10:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Magic number: 10, in detected (mnd)

break
}
}
case 11:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Magic number: 11, in detected (mnd)

break
}
}
case 12:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Magic number: 12, in detected (mnd)

break
}
}
case 13:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
Magic number: 13, in detected (mnd)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment