feat/apis: add algorithm-specific payload options by Matts966 · Pull Request #3589 · vdaas/vald

Matts966 · 2026-08-05T04:32:24Z

Summary

add algorithm-specific google.protobuf.Any options to Search and Insert payload configs
preserve existing Remove timestamp enum identifiers in generated Go code
initialize the new Insert options field in Rust upsert conversions
keep all ZVec-specific message definitions and runtime changes out of this PR

Verification

make proto/all (Buf generation succeeded; repository replacements were applied in smaller batches because macOS xargs exceeded its command-line limit)
make license
GitHub Build protobuf check passed on the rebased head

Stacked PR

#3574 is based on feature/grpc/common-any-args and contains the ZVec-specific messages and implementation.

coderabbitai · 2026-08-05T04:32:32Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

vdaas-ci · 2026-08-05T04:32:34Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-v2 - run E2E deploy & integration test (tests/v2/e2e)

Matts966 · 2026-08-07T06:44:58Z

/format

vdaas-ci · 2026-08-07T06:46:26Z

[FORMAT] Updating license headers and formatting go codes triggered by Matts966.

cloudflare-workers-and-pages · 2026-08-07T06:51:29Z

Deploying vald with Cloudflare Pages

Latest commit:	`469364f`
Status:	✅ Deploy successful!
Preview URL:	https://12648772.vald.pages.dev
Branch Preview URL:	https://feature-grpc-common-any-args.vald.pages.dev

View logs

vdaas-ci · 2026-08-07T06:57:24Z

[FORMAT] Failed to format.

Matts966 · 2026-08-12T03:10:14Z

/format

vdaas-ci · 2026-08-12T03:12:19Z

[FORMAT] Updating license headers and formatting go codes triggered by Matts966.

Matts966 · 2026-08-12T03:19:04Z

/format

vdaas-ci · 2026-08-12T03:22:10Z

[FORMAT] Updating license headers and formatting go codes triggered by Matts966.

vdaas-ci · 2026-08-12T03:22:33Z

[FORMAT] Failed to format.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 11, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28238 in e7bf077

case 11:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 12, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28257 in e7bf077

case 12:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 13, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28276 in e7bf077

case 13:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 14, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28295 in e7bf077

case 14:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 15, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28314 in e7bf077

case 15:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 16, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28333 in e7bf077

case 16:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 17, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28352 in e7bf077

case 17:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 18, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28371 in e7bf077

case 18:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 19, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28390 in e7bf077

case 19:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 20, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28409 in e7bf077

case 20:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 21, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28428 in e7bf077

case 21:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 22, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28439 in e7bf077

case 22:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 23, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28450 in e7bf077

case 23:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 24, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28461 in e7bf077

case 24:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 25, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28472 in e7bf077

case 25:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 26, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28483 in e7bf077

case 26:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 27, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28494 in e7bf077

case 27:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 28, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28505 in e7bf077

case 28:

🚫 [golangci] _{reported by reviewdog 🐶}
ST1006: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (staticcheck)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 2864 in e7bf077

func (this *ZVec_DocumentOptions) EqualVT(that *ZVec_DocumentOptions) bool {

🚫 [golangci] _{reported by reviewdog 🐶}
ST1006: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (staticcheck)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 2885 in e7bf077

func (this *ZVec_DocumentOptions) EqualMessageVT(thatMsg proto.Message) bool {

🚫 [golangci] _{reported by reviewdog 🐶}
unnecessary conversion (unconvert)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 6634 in e7bf077

binary.LittleEndian.PutUint32(dAtA[i:], uint32(f1))

Matts966 · 2026-08-12T04:10:11Z

/format

vdaas-ci · 2026-08-12T04:11:27Z

[FORMAT] Updating license headers and formatting go codes triggered by Matts966.

Signed-off-by: Vdaas CI <vald@vdaas.org>

github-actions · 2026-09-30T04:14:45Z

@@ -19398,6 +19362,40 @@ func (m *Search_Config) UnmarshalVT(dAtA []byte) error {
 					break
 				}
 			}
+		case 13:


🚫 [golangci] _{reported by reviewdog 🐶}
19365-19398 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:20617-20650 (dupl)

github-actions · 2026-09-30T04:14:45Z

@@ -20628,6 +20614,40 @@ func (m *Insert_Config) UnmarshalVT(dAtA []byte) error {
 					break
 				}
 			}
+		case 4:


🚫 [golangci] _{reported by reviewdog 🐶}
20617-20650 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:31547-31580 (dupl)

github-actions · 2026-09-30T04:14:45Z

@@ -31610,6 +31544,40 @@ func (m *Search_Config) UnmarshalVTUnsafe(dAtA []byte) error {
 					break
 				}
 			}
+		case 13:


🚫 [golangci] _{reported by reviewdog 🐶}
31547-31580 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:32807-32840 (dupl)

github-actions · 2026-09-30T04:14:46Z

@@ -32848,6 +32804,40 @@ func (m *Insert_Config) UnmarshalVTUnsafe(dAtA []byte) error {
 					break
 				}
 			}
+		case 4:


🚫 [golangci] _{reported by reviewdog 🐶}
32807-32840 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:19365-19398 (dupl)

Matts966 mentioned this pull request Aug 5, 2026

feat/apis: add algorithm-specific payload options #3588

Closed

github-actions Bot added size/XL and removed size/XL labels Aug 12, 2026

github-actions Bot reviewed Aug 12, 2026

View reviewed changes

github-actions Bot added size/XL and removed size/XL labels Aug 12, 2026

Matts966 and others added 6 commits September 30, 2026 12:41

feat/apis: add algorithm-specific payload options

ff6773a

fix(rust): initialize insert options in upsert

4bde33a

fix(apis): preserve timestamp operator names

fcf5113

🤖 Update license headers / Format go codes and yaml files

fb322d2

Signed-off-by: Vdaas CI <vald@vdaas.org>

🤖 Update license headers / Format go codes and yaml files

a8fd2a2

Signed-off-by: Vdaas CI <vald@vdaas.org>

refactor(apis): move zvec payload options out of common API

469364f

Matts966 force-pushed the feature/grpc/common-any-args branch from ee05196 to 469364f Compare September 30, 2026 04:03

github-actions Bot added the size/M label Sep 30, 2026

Matts966 mentioned this pull request Sep 30, 2026

Add Zvec Agent #3574

Draft

github-actions Bot removed the size/M label Sep 30, 2026

github-actions Bot reviewed Sep 30, 2026

View reviewed changes

Navigation Menu

feat/apis: add algorithm-specific payload options - #3589

feat/apis: add algorithm-specific payload options#3589
Matts966 wants to merge 6 commits into
mainfrom
feature/grpc/common-any-args

Matts966 commented Aug 5, 2026 •

edited

Loading

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

Draft PR not reviewed

vdaas-ci commented Aug 5, 2026

Matts966 commented Aug 7, 2026

vdaas-ci commented Aug 7, 2026

cloudflare-workers-and-pages Bot commented Aug 7, 2026 •

edited

Loading

vdaas-ci commented Aug 7, 2026

Matts966 commented Aug 12, 2026

vdaas-ci commented Aug 12, 2026

Matts966 commented Aug 12, 2026

vdaas-ci commented Aug 12, 2026

vdaas-ci commented Aug 12, 2026

github-actions Bot left a comment

Matts966 commented Aug 12, 2026

vdaas-ci commented Aug 12, 2026

github-actions Bot Sep 30, 2026

github-actions Bot Sep 30, 2026

github-actions Bot Sep 30, 2026

github-actions Bot Sep 30, 2026

This branch has not been deployed

Labels

2 participants

Conversation

Matts966 commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Stacked PR

coderabbitai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Draft PR not reviewed

vdaas-ci commented Aug 5, 2026

Matts966 commented Aug 7, 2026

vdaas-ci commented Aug 7, 2026

cloudflare-workers-and-pages Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying vald with Cloudflare Pages

vdaas-ci commented Aug 7, 2026

Matts966 commented Aug 12, 2026

vdaas-ci commented Aug 12, 2026

Matts966 commented Aug 12, 2026

vdaas-ci commented Aug 12, 2026

vdaas-ci commented Aug 12, 2026

github-actions Bot left a comment

Choose a reason for hiding this comment

Matts966 commented Aug 12, 2026

vdaas-ci commented Aug 12, 2026

github-actions Bot Sep 30, 2026

Choose a reason for hiding this comment

github-actions Bot Sep 30, 2026

Choose a reason for hiding this comment

github-actions Bot Sep 30, 2026

Choose a reason for hiding this comment

github-actions Bot Sep 30, 2026

Choose a reason for hiding this comment

This branch has not been deployed

Labels

2 participants

Matts966 commented Aug 5, 2026 •

edited

Loading

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Aug 7, 2026 •

edited

Loading